feat(libsinsp): Add wrapper for read/write lock #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
release-note-none
kind/feature
Molter73
reviewed
May 23, 2024
|
/milestone 0.18.0 |
greyhame-s
force-pushed
the
master
branch
2 times, most recently
from
a8b0cca to
b6b3335
Compare
`mutex.h` already has a nice abstraction that allows exclusive access to an object. This change extends that paradigm to allow similar simple function calls that allow read/write locking primitives using a `shared_mutex`. Signed-off-by: Sahas Panda <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, greyhame-s The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 6b590b386fabe27e036d12d7aa211685759b18e9
|
LucaGuerra
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
mutex.halready has a nice abstraction that allows exclusive access to an object. This change extends that paradigm to allow similar simple function calls that allow read/write locking primitives using ashared_mutex.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The timekeeping stats were useful to me during testing, but I am not married to them. It also looks like the
.clang-formatin the root directory, when applied to this file, resulted in some whitespace changes to otherwise unchanged code. If that is not expected, then I can revert the formatting to existing lines as well.Does this PR introduce a user-facing change?:
No